[PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 30 13:43:49 PDT 2016


rsmith added inline comments.

================
Comment at: lib/CodeGen/CGExpr.cpp:438
@@ -426,1 +437,3 @@
+    }
     EmitAnyExprToMem(E, Object, Qualifiers(), /*IsInit*/true);
+    if (Size) {
----------------
Seems like you should push the cleanup before you emit the initializer; the cleanup should run if the initializer throws.


http://reviews.llvm.org/D20499





More information about the cfe-commits mailing list