[PATCH] D18171: [CUDA][OpenMP] Create generic offload action

[Alexey Bataev via cfe-commits]

ABataev added a comment.

No '\brief's


================
Comment at: include/clang/Driver/Action.h:204
@@ -159,1 +203,3 @@
+/// kind to its dependences.
+class OffloadAction : public Action {
   virtual void anchor();
----------------
'final'

================
Comment at: include/clang/Driver/Action.h:209
@@ +208,3 @@
+  /// architecture, toolchain, and offload kind to each action.
+  class DeviceDependences {
+  public:
----------------
'final'

================
Comment at: include/clang/Driver/Action.h:247
@@ +246,3 @@
+  /// architecture, toolchain, and offload kinds to the host action.
+  class HostDependence {
+    /// \brief The dependence action.
----------------
'final'

================
Comment at: include/clang/Driver/Action.h:253-255
@@ +252,5 @@
+    /// \brief The architectures that should be used with this action.
+    const char *HostBoundArch;
+    /// \brief The offload kind of each dependence.
+    unsigned HostOffloadKinds;
+
----------------
default initializers

================
Comment at: include/clang/Driver/Action.h:277
@@ +276,3 @@
+  /// \brief The host offloading toolchain that should be used with the action.
+  const ToolChain *HostTC;
+
----------------
Default initializer

================
Comment at: lib/Driver/Driver.cpp:1942-1945
@@ -1877,2 +1941,6 @@
 }
-
+// Collapse an offloading action looking for a job of the given type. The input
+// action is changed to the input of the collapsed sequence. If we effectively
+// had a collapse return the corresponding offloading action, otherwise return
+// null.
+template <typename T>
----------------
Three slashes


http://reviews.llvm.org/D18171