[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder
Alexey Bataev via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 29 21:31:07 PDT 2016
ABataev added a comment.
No '\brief's
================
Comment at: lib/Driver/Driver.cpp:1393
@@ +1392,3 @@
+/// generate the required device actions.
+class OffloadingActionBuilder {
+ /// \brief Flag used to trace errors in the builder.
----------------
1. 'final'
2. default initializers for fields
================
Comment at: lib/Driver/Driver.cpp:1437
@@ +1436,3 @@
+ /// \brief The associated offload kind.
+ Action::OffloadKind AssociatedOffloadKind;
+
----------------
default initializer
================
Comment at: lib/Driver/Driver.cpp:1486
@@ +1485,3 @@
+ /// action.
+ class CudaActionBuilder : public DeviceActionBuilder {
+ /// \brief Flags to signal if the user requested host-only or device-only
----------------
'final'
http://reviews.llvm.org/D18172
More information about the cfe-commits
mailing list