[PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

[Alexey Bataev via cfe-commits]

ABataev added inline comments.

================
Comment at: include/clang/Driver/Compilation.h:73
@@ +72,3 @@
+  /// architecture, and device offload kind.
+  struct TCArgsKey {
+    const ToolChain *TC;
----------------
1. 'final'
2. default initializers for fields.

================
Comment at: include/clang/Driver/Compilation.h:206
@@ +205,3 @@
+  const llvm::opt::DerivedArgList &
+  getArgsForToolChain(const ToolChain *TC, const char *BoundArch,
+                      Action::OffloadKind DeviceOffloadKind);
----------------
'const' function?

================
Comment at: lib/Driver/Compilation.cpp:40
@@ -39,5 +39,3 @@
   // Free any derived arg lists.
-  for (llvm::DenseMap<std::pair<const ToolChain*, const char*>,
-                      DerivedArgList*>::iterator it = TCArgs.begin(),
-         ie = TCArgs.end(); it != ie; ++it)
+  for (auto it = TCArgs.begin(), ie = TCArgs.end(); it != ie; ++it)
     if (it->second != TranslatedArgs)
----------------
for(auto &Arg : TCArgs)


http://reviews.llvm.org/D21848