[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 20:26:45 PDT 2016


ABataev added inline comments.

================
Comment at: include/clang/Driver/Action.h:493
@@ -491,1 +492,3 @@
 
+class OffloadUnbundlingJobAction : public JobAction {
+  void anchor() override;
----------------
'final'?

================
Comment at: include/clang/Driver/Action.h:499
@@ +498,3 @@
+  /// this unbundling action.
+  struct DependingActionInfoTy {
+    /// \brief The tool chain of the depending action.
----------------
1. 'final'?
2. Default initializers for fields

================
Comment at: include/clang/Driver/Types.h:78
@@ +77,3 @@
+  /// compilation phase is a preprocessor one.
+  bool isSrcFile(ID Id);
+
----------------
'const'?


http://reviews.llvm.org/D21853





More information about the cfe-commits mailing list