[PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.
Alexey Bataev via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 29 20:18:25 PDT 2016
ABataev added a comment.
Remove '\brief'
================
Comment at: include/clang/Driver/Action.h:158-160
@@ -158,1 +157,5 @@
+ /// non-device kinds, except if \a CreatePrefixForHost is set.
+ static std::string
+ getOffloadingFileNamePrefix(OffloadKind Kind, StringRef NormalizedTriple,
+ bool CreatePrefixForHost = false);
/// \brief Return a string containing a offload kind name.
----------------
Can this be 'static'? Also, name of the function must start from capital letter.
================
Comment at: include/clang/Driver/Tool.h:132-140
@@ -131,1 +131,11 @@
const char *LinkingOutput) const = 0;
+ /// ConstructJob - Construct jobs to perform the action \p JA,
+ /// writing to the \p Outputs and with \p Inputs, and add the jobs to
+ /// \p C. The default implementation assumes a single output and is expected
+ /// to be overloaded for the tools that support multiple inputs.
+ ///
+ /// \param TCArgs - The argument list for this toolchain, with any
+ /// tool chain specific translations applied.
+ /// \param LinkingOutput - If this output will eventually feed the
+ /// linker, then this is the final output name of the linked image.
+ virtual void ConstructJob(Compilation &C, const JobAction &JA,
----------------
Please, format properly. Remove the name of the function and '-' signs after params
http://reviews.llvm.org/D21857
More information about the cfe-commits
mailing list