[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

[Alexey Bataev via cfe-commits]

ABataev added inline comments.

================
Comment at: include/clang/Driver/Action.h:158
@@ -157,1 +157,3 @@
   std::string getOffloadingFileNamePrefix(StringRef NormalizedTriple) const;
+  /// \brief Return a string containing a offload kind name.
+  static std::string getOffloadKindName(OffloadKind Kind);
----------------
'\brief'

================
Comment at: lib/Driver/Action.cpp:133
@@ +132,3 @@
+/// we assume 'host'.
+std::string Action::getOffloadKindName(OffloadKind Kind) {
+  switch (Kind) {
----------------
1. Maybe it is enough to return just StringRef, rather than std::string
2. This can be made 'static'

================
Comment at: lib/Driver/Tools.h:139
@@ +138,3 @@
+/// \brief Offload bundler tool.
+class LLVM_LIBRARY_VISIBILITY OffloadBundler : public Tool {
+public:
----------------
'final'?


http://reviews.llvm.org/D21856