[PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 19:48:02 PDT 2016


ABataev added inline comments.

================
Comment at: lib/Driver/Driver.cpp:464-468
@@ +463,7 @@
+          RuntimeName = A->getValue();
+        HasCompatibleOpenMP = llvm::StringSwitch<bool>(RuntimeName)
+                                  .Case("libomp", true)
+                                  .Case("libgomp", false)
+                                  .Case("libiomp5", true)
+                                  .Default(false);
+      }
----------------
I don't like the fact that we have similar string comparisons in different files. This must be handled in a single place.


http://reviews.llvm.org/D21843





More information about the cfe-commits mailing list