[PATCH] D21834: Implementing 'If statement with Initializer'

Anton Bikineev via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 17:14:01 PDT 2016


AntonBikineev added a comment.

@rsmith,

> This is not correct; TryParseSimpleDeclaration usually stops long before it reaches the end of the simple-declaration, so this will give false negatives in lots of cases.


Yes, I noticed that, that's why I changed use of TryParseSimpleDeclaration to something easier in last revision.

Thanks for reply, Richard. The revision you sent looks great, I should have updated my working copy before :)
Anyways, there are not too much of changes to Sema/AST stuff, I just applied them on top of yours, added the same for SwitchStmt. I'll update the test you put according to my changes tomorrow.


http://reviews.llvm.org/D21834





More information about the cfe-commits mailing list