[PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 10:52:53 PDT 2016


rmaprath added a comment.

In http://reviews.llvm.org/D21803#470060, @tavianator wrote:

> In http://reviews.llvm.org/D21803#469988, @bcraig wrote:
>
> > @rmaprath has been doing some work to make the threading runtime library swappable.  I don't recall if his work extended to libcxxabi or not, but I'll page him anyway.
>
>
> <__threading_support>?  Seems to be libc++-specific.  There's a few other raw uses of pthreads in libc++abi.


Plan to get started with `libc++abi` as soon as I'm done with `libc++`, I've hit a couple of bumps with the latter, resolving them at the moment.

I don't see any new `pthread` dependencies introduced in this patch, so it sounds OK to me. Thanks for the ping though!

The patch itself looks OK to me. Will need approval from @mclow.lists or @ericwf.


http://reviews.llvm.org/D21803





More information about the cfe-commits mailing list