[PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

[Sean Silva via cfe-commits]

silvas added a comment.

Some basic comments.


================
Comment at: include/clang/Driver/Options.td:483
@@ +482,3 @@
+    Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<file>">,
+    HelpText<"Generate instrumented code to collect execution counts into <file> (overridden by LLVM_PROFILE_FILE env var)">;
+def fpgo_apply_EQ : Joined<["-"], "fpgo-apply=">,
----------------
This help text is stale.

================
Comment at: include/clang/Driver/Options.td:486
@@ -481,1 +485,3 @@
+    Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<file>">,
+    HelpText<"Use instrumentation data for profile-guided optimization">;
 def fprofile_instr_use : Flag<["-"], "fprofile-instr-use">, Group<f_Group>,
----------------
You should probably update this help text to say something about applying.

================
Comment at: lib/Driver/Tools.cpp:3474
@@ +3473,3 @@
+
+  auto *ProfileTrainingArg =
+      Args.getLastArg(options::OPT_fpgo_train_EQ,
----------------
Call this PGOTrainArg for consistency.

================
Comment at: lib/Driver/Tools.cpp:3496
@@ +3495,3 @@
+
+  auto *ProfileApplyArg =
+      Args.getLastArg(options::OPT_fpgo_apply_EQ, options::OPT_fno_pgo_apply);
----------------
Call this PGOApplyArg for consistency.


Repository:
  rL LLVM

http://reviews.llvm.org/D21823