[PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

[Teresa Johnson via cfe-commits]

tejohnson added a comment.

Sorry for the delay, comments below.


================
Comment at: lib/CodeGen/BackendUtil.cpp:733
@@ +732,3 @@
+  StringMap<FunctionImporter::ExportSetTy> ExportLists;
+  ComputeCrossModuleImport(*CombinedIndex, ModuleToDefinedGVSummaries,
+                           ImportLists, ExportLists);
----------------
Use ComputeCrossModuleImportForModule instead, since this is only for a single module and we don't need the ExportLists (and is the same routine invoked currently by the FunctionImportPass).

================
Comment at: lib/CodeGen/BackendUtil.cpp:749
@@ +748,3 @@
+    ModuleMap[I.first()] = (*MBOrErr)->getMemBufferRef();
+    OwnedImports.push_back(std::move(*MBOrErr));
+  }
----------------
OwnedImports is never read from.

================
Comment at: lib/Driver/Tools.cpp:3894
@@ -3893,1 +3893,3 @@
                                                        << "-x ir";
+    if (!isa<AssembleJobAction>(JA))
+      D.Diag(diag::err_drv_argument_only_allowed_with) << A->getAsString(Args)
----------------
This change and the associated test change seem independent of the rest of the patch and could be submitted now independently.


http://reviews.llvm.org/D21545