[PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 26 11:04:32 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with a couple of nits.


================
Comment at: test/clang-tidy/boost-use-to-string.cpp:154
@@ +153,3 @@
+  float floating;
+  Fields* wierd;
+  const int &getConstInteger() const {return integer;}
----------------
"wierd" is weird ;)

================
Comment at: test/clang-tidy/boost-use-to-string.cpp:161
@@ +160,3 @@
+  auto s1 = boost::lexical_cast<std::string>(fields.integer);
+  // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: use std::to_string{{..}}
+  // CHECK-FIXES: auto s1 = std::to_string(fields.integer);
----------------
nit: The `{{..}}` part doesn't seem to be useful. Above as well.


http://reviews.llvm.org/D21642





More information about the cfe-commits mailing list