[clang-tools-extra] r273660 - Remove ignoringImplicit from clang-tidy.

Cong Liu via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 24 04:10:45 PDT 2016


It was the previous revision that broke tests,
http://reviews.llvm.org/rL273659. It moved ignoringImplicit to ASTMatcher,
caused some namespace conflict in clang-tidy/misc/DanglingHandleCheck.cpp.
And r273660 solves that, tests are not broken after this revision.

On Fri, Jun 24, 2016 at 12:32 PM Renato Golin <renato.golin at linaro.org>
wrote:

> On 24 June 2016 at 10:39, Cong Liu via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> > Author: congliu
> > Date: Fri Jun 24 04:39:28 2016
> > New Revision: 273660
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=273660&view=rev
> > Log:
> > Remove ignoringImplicit from clang-tidy.
>
> Hi Cong,
>
> Isn't this leaving untested code in tree? Shouldn't you have reverted
> the patch instead?
>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160624/fda54bf0/attachment.html>


More information about the cfe-commits mailing list