[PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

Hans Wennborg via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 22 09:10:09 PDT 2016


hans added a comment.

Thanks for the review! Please take another look.


================
Comment at: lib/CodeGen/CGCleanup.h:93
@@ -92,3 +92,3 @@
     /// from this index onwards belong to this scope.
-    unsigned FixupDepth : 32 - 18 - NumCommonBits; // currently 12
+    unsigned FixupDepth;
   };
----------------
rjmccall wrote:
> This should just be pulled out of the BitFields structure and into the EHCleanup class.
That's probably a better way to do it. Thanks.


http://reviews.llvm.org/D21566





More information about the cfe-commits mailing list