[PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

[Piotr Padlewski via cfe-commits]

Prazek added inline comments.

================
Comment at: clang-tidy/performance/ReturnValueCopyCheck.cpp:107-108
@@ +106,4 @@
+                       InnerMatcher) {
+  return hasDeclaration(
+      cxxRecordDecl(hasDescendant(cxxConstructorDecl(InnerMatcher))));
+}
----------------
You have bug here, but it should not affect the check - 
hasDescendant(cxxConstructorDecl()) could possibly match to constructor of another class defined inside class.

Try
cxxRecordDecl(hasMethod(cxxConstructorDecl(InnerMatcher))))


http://reviews.llvm.org/D21303