[PATCH] D21507: Changes after running check modernize-use-emplace (D20964)

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 20 09:36:58 PDT 2016


jlebar added a subscriber: jlebar.
jlebar added a comment.

There seem to be many nontrivial whitespace errors introduced by this patch.  For example,

  -        Attrs.push_back(HTMLStartTagComment::Attribute(Ident.getLocation(),
  -                                                       Ident.getHTMLIdent()));
  +        Attrs.emplace_back(Ident.getLocation(),
  +                                                       Ident.getHTMLIdent());

and

  -        BitGroups.push_back(BitGroup(LastValue, LastRLAmt, LastGroupStartIdx,
  -                                     i-1));
  +        BitGroups.emplace_back(LastValue, LastRLAmt, LastGroupStartIdx,
  +                                     i-1);


Repository:
  rL LLVM

http://reviews.llvm.org/D21507





More information about the cfe-commits mailing list