[PATCH] D21517: clang-rename: add a -old-name option

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 20 08:12:34 PDT 2016


klimek added inline comments.

================
Comment at: clang-rename/USRFinder.h:28-33
@@ -27,6 +27,8 @@
 
-// Given an AST context and a point, returns a NamedDecl identifying the symbol
-// at the point. Returns null if nothing is found at the point.
+// Given an AST context and a point (or fully qualified name), returns a
+// NamedDecl identifying the symbol at the point. Returns null if nothing is
+// found at the point.
 const NamedDecl *getNamedDeclAt(const ASTContext &Context,
-                                const SourceLocation Point);
+                                const SourceLocation Point,
+                                const std::string &Name);
 
----------------
These seem to be fundamentally different use cases. Can we add a new top-level function instead?
It seems like the new case would have a much simpler implementation.


http://reviews.llvm.org/D21517





More information about the cfe-commits mailing list