[PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Piotr Padlewski via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 19 12:53:18 PDT 2016


Prazek added a comment.

In http://reviews.llvm.org/D20964#453797, @vsk wrote:

> @Eugene.Zelenko thanks for pointing this out, I had totally missed this patch! Once we get this reviewed I'm willing to abandon my version. Some comments inline --


I have tested it on llvm code base and I have found many, many corner cases. I see that your check have better fixit messages (it only prints change of push_back -> emplace_back). I guess the best idea is to push this check, and then if you would like, change it so it would also have nice fixit messages


http://reviews.llvm.org/D20964





More information about the cfe-commits mailing list