[PATCH] D17462: Fix a codegen bug for variadic functions with pass_object_size params

George Burgess IV via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 16 15:28:48 PDT 2016


george.burgess.iv added inline comments.

================
Comment at: lib/CodeGen/CGExprCXX.cpp:331
@@ -329,3 +330,3 @@
   // And the rest of the call args
   EmitCallArgs(Args, FPT, E->arguments(), E->getDirectCallee());
   return EmitCall(CGM.getTypes().arrangeCXXMethodCall(Args, FPT, required),
----------------
rsmith wrote:
> Seems inconsistent to pass `E->getDirectCallee()` here but not above. Since you can't take the address of a pass_object_size function, do we need to pass the callee in either place?
Good point. :)


http://reviews.llvm.org/D17462





More information about the cfe-commits mailing list