[PATCH] D21396: [libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 15 12:39:54 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL272821: [libcxxabi] Reorder base class initializers in libc++abi tests to prevent… (authored by EricWF).

Changed prior to commit:
  http://reviews.llvm.org/D21396?vs=60876&id=60881#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D21396

Files:
  libcxxabi/trunk/test/catch_class_04.pass.cpp
  libcxxabi/trunk/test/catch_ptr.pass.cpp

Index: libcxxabi/trunk/test/catch_ptr.pass.cpp
===================================================================
--- libcxxabi/trunk/test/catch_ptr.pass.cpp
+++ libcxxabi/trunk/test/catch_ptr.pass.cpp
@@ -66,8 +66,8 @@
 {
     static int count;
     int id_;
-    explicit A(int id) : C1(id-1), C2(id-2), B(id+3), id_(id) {count++;}
-    A(const A& a) : C1(a.id_-1), C2(a.id_-2), B(a.id_+3), id_(a.id_) {count++;}
+    explicit A(int id) : B(id+3), C1(id-1), C2(id-2), id_(id) {count++;}
+    A(const A& a) : B(a.id_+3), C1(a.id_-1), C2(a.id_-2),  id_(a.id_) {count++;}
     ~A() {count--;}
 };
 
Index: libcxxabi/trunk/test/catch_class_04.pass.cpp
===================================================================
--- libcxxabi/trunk/test/catch_class_04.pass.cpp
+++ libcxxabi/trunk/test/catch_class_04.pass.cpp
@@ -66,8 +66,8 @@
 {
     static int count;
     int id_;
-    explicit A(int id) : C1(id-1), C2(id-2), B(id+3), id_(id) {count++;}
-    A(const A& a) : C1(a.id_-1), C2(a.id_-2), B(a.id_+3), id_(a.id_) {count++;}
+    explicit A(int id) : B(id+3), C1(id-1), C2(id-2), id_(id) {count++;}
+    A(const A& a) :  B(a.id_+3), C1(a.id_-1), C2(a.id_-2), id_(a.id_) {count++;}
     ~A() {count--;}
 };
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21396.60881.patch
Type: text/x-patch
Size: 1213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160615/7b1576e4/attachment.bin>


More information about the cfe-commits mailing list