[PATCH] D21350: [libcxx] [test] Avoid C++17 terse static_assert.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 14 14:25:37 PDT 2016


STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

TOTALLY OPTIONAL, feel free to reject this, I won't mind.

Newly-added libcxx tests for C++17 features have been using C++17 terse static_asserts occasionally. This is problematic for MSVC at the moment, since the compiler doesn't yet support the terse form. Changing the tests to always use the original recipe static_assert instead of extra crispy allows them to pass when we have the corresponding library support.

MSVC will be gaining support for the terse form soon, which will make this a non-issue for me, but I wanted to send out this change just in case you thought it was a worthwhile improvement in consistency.

http://reviews.llvm.org/D21350

Files:
  test/std/utilities/function.objects/func.invoke/invoke.pass.cpp
  test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
  test/std/utilities/meta/meta.rel/is_callable.pass.cpp
  test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp
  test/std/utilities/meta/meta.unary/meta.unary.prop/is_nothrow_swappable.pass.cpp
  test/std/utilities/meta/meta.unary/meta.unary.prop/is_nothrow_swappable_with.pass.cpp
  test/std/utilities/meta/meta.unary/meta.unary.prop/is_swappable.pass.cpp
  test/std/utilities/meta/meta.unary/meta.unary.prop/is_swappable_with.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21350.60754.patch
Type: text/x-patch
Size: 24664 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160614/3d8f1f24/attachment-0001.bin>


More information about the cfe-commits mailing list