Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

Hans Wennborg via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 14 12:34:05 PDT 2016


SGTM, then :-)

On Tue, Jun 14, 2016 at 11:54 AM, Nico Weber <thakis at chromium.org> wrote:
> I locally set up an SVN repo with a file called "File.txt" and then renamed
> it with `svn mv` using a new svn client (1.8).
>
> Then I tried updating several local checkouts of my local repo with svn
> 1.6.6 clients. All methods of updating I tried (`svn up`, `svn co
> current_checkout_url at 2`) worked without problems. So this does seem to work
> fine as far as I can tell.
>
> On Wed, Jun 8, 2016 at 1:38 PM, Nico Weber <thakis at chromium.org> wrote:
>>
>> On Wed, Jun 8, 2016 at 1:27 PM, Hans Wennborg <hans at chromium.org> wrote:
>>>
>>> On Wed, Jun 8, 2016 at 10:20 AM, Nico Weber <thakis at chromium.org> wrote:
>>> > It looks like we're starting to be more careful about header case.
>>> > MSVC's
>>> > intrin.h is called intrin.h with a lower-case 'i'; ours starts with an
>>> > upper-case 'I' for no good reason.
>>> >
>>> > It looks like file-only renames work fine as of svn 1.7 without any
>>> > workarounds
>>> >
>>> > (http://subversion.apache.org/docs/release-notes/1.7.html#windows-case-change),
>>> > so let's `svn mv` the file to its correct case.
>>> >
>>> > SGTM?
>>>
>>> Hmm, from http://subversion.apache.org/faq.html#case-change it seems
>>> users with pre-1.7 svn might run into problems when updating past the
>>> name change? Do users with such ancient versions still exist? Turns
>>> out I seem to be on svn 1.6.6 myself :-/
>>
>>
>> 1.7 was released 6 years ago. I think it's ok if people who use an old svn
>> need to do some manual work when they update. I can mention what people need
>> to do in the CL description (also explained at
>> http://subversion.apache.org/faq.html#case-change).
>>
>> I'm guessing most people get clang via the git mirror, and I think with
>> git this will hopefully just work (?)
>>
>> Anyone else out there still on svn 1.6? Hans uses Chromium's depot_tools
>> svn (and Chromium's clang/win/tot bots do too, so they'll need some care),
>> but I'd expect that most people who don't happen to work on Chromium
>> probably have a newer svn by now?
>>
>


More information about the cfe-commits mailing list