[PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 14 11:45:33 PDT 2016


EricWF added a comment.

In http://reviews.llvm.org/D21098#457726, @STL_MSFT wrote:

> [Eric Fiselier]
>
> > Please change the `TEST_HAS_FEATURE(XXX)` into `TEST_STD_VER >= 11` for the following C++11 features:
>
> > 
>
> > - `cxx_noexcept`
>
> > - `cxx_atomic`
>
> > - `cxx_access_control_sfinae` Also if the entire test is wrapped in a `TEST_HAS_FEATURE(XXX)` please translate that into a `// UNSUPPORTED: c++98, c++03` comment at the top of the file.
>
>
> Sure. Would you like cxx_attributes and/or cxx_strong_enums to receive the same treatment?


Yeah, `cxx_strong_enums` and `cxx_attributes` can be changed as well. I wasn't on top of it last night apparently.

Thank you for this patch. I know it's huge but it's also a huge improvement.

> STL





http://reviews.llvm.org/D21098





More information about the cfe-commits mailing list