[PATCH] D21323: [clang-format] do not add existing includes.

Daniel Jasper via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 14 06:47:37 PDT 2016


djasper added inline comments.

================
Comment at: unittests/Format/CleanupTest.cpp:693
@@ +692,3 @@
+  std::string Code = "#include \"a.h\"\n#include <vector>\n";
+  std::string Expected = "#include \"a.h\"\n#include <vector>\n";
+  tooling::Replacements Replaces = {createInsertion("#include <vector>"),
----------------
Please add a line break after each "\n", i.e.:

  ... = "#include \"a.h\"\n"
        "#include <vector>";

================
Comment at: unittests/Format/CleanupTest.cpp:701
@@ +700,3 @@
+  std::string Code = "#include \"a.h\"\n#include <vector>\n";
+  std::string Expected = "#include \"a.h\"\n#include \"vector\"\n"
+                         "#include <vector>\n#include <a.h>\n";
----------------
Is this really what we want?


http://reviews.llvm.org/D21323





More information about the cfe-commits mailing list