[PATCH] D21243: Fix clang-tidy patterns to adapt to newly added ExprWithCleanups nodes.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 13 05:10:52 PDT 2016


alexfh added a comment.

In http://reviews.llvm.org/D21243#455999, @alexfh wrote:

> Does this just fix the tests broken with http://reviews.llvm.org/D20498 or have you looked at other checks that might be broken by http://reviews.llvm.org/D20498, but don't have relevant tests? In the latter case we'd certainly need your help figuring out where further problems may appear, e.g. what specific patterns should we look for in the AST matchers used in clang-tidy checks or other Clang tools. Does this boil down to `expr(X)` -> `expr(ignoringExprWithCleanups(X))`?


Actually, the more interesting question is what patterns in the analyzed code generate `ExprWithCleanups`?


http://reviews.llvm.org/D21243





More information about the cfe-commits mailing list