[PATCH] D19260: [analyzer][scan-build-py] subprocess output handling reviewed in clang module

[Laszlo Nagy via cfe-commits]

rizsotto.mailinglist added a comment.

hey Devin, thanks for looking to it.


================
Comment at: tools/scan-build-py/libscanbuild/clang.py:90
@@ -89,2 +89,3 @@
 
-    {<plugin name>: (<plugin description>, <is active by default>)} """
+    predicate.patterns = [re.compile(r'^' + a + r'(\.|$)') for a in checkers]
+    return predicate
----------------
dcoughlin wrote:
> What's the benefit of using a function attribute here rather than simply closing over a local variable?
there is no difference between the two. (it even can be written in the same order.) i guess, just wanted to decorate the name of the variable. i have no preference.


http://reviews.llvm.org/D19260