[PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

[Cameron via cfe-commits]

cameron314 added inline comments.

================
Comment at: lib/Basic/FileManager.cpp:389
@@ -383,2 +388,3 @@
   UFE->File.reset();
+  UFE->IsVirtual = true;
   return UFE;
----------------
rsmith wrote:
> Yes. The `IsValid` flag is just supposed to mean that this file has actually been added to the `UniqueRealFiles` map rather than having been default-constructed by `operator[]`.
Excellent then, I'll get rid of `IsVirtual` and use `IsValid` in place. This will condense things down to a one-line change plus a large diff for the test ^^


http://reviews.llvm.org/D20338