[PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

[Eric Niebler via cfe-commits]

eric_niebler added a comment.

> Before this goes in again, I want to double check that this doesn't affect compile time on darwin + frameworks.


@bruno, you're not likely to find a difference for darwin + frameworks since the frameworks headers like `Cocoa/Cocoa.h` don't exist on-disk with that path -- at least not on my machine. As a result, the attempt to get the "real path name" fails and no diagnostic is issued; the code path you want to measure will never be hit. This appears to be a shortcoming of the way I'm trying to get the true case of the files as they are opened. Correctly handing this would greatly increase the complexity of the patch. Apple == :-(


http://reviews.llvm.org/D19843