[PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Eric Niebler via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 8 14:41:05 PDT 2016


eric_niebler added inline comments.

================
Comment at: lib/Lex/PPDirectives.cpp:33
@@ -28,2 +32,2 @@
 #include "llvm/Support/Path.h"
 #include "llvm/Support/SaveAndRestore.h"
----------------
You mean, instead of the `StringSet` below? Looks like `StringSwitch` just turns into cascading `memcmp`'s. Bet I can tell you how that performs versus a hash set. :-) Also, with the `StringSet`, I get to initialize it once and reuse it many times. I expect that will be pretty darn quick at runtime, but I'm looking forward to @bruno's results.


http://reviews.llvm.org/D19843





More information about the cfe-commits mailing list