[PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

[Bruno Cardoso Lopes via cfe-commits]

bruno added a comment.

Before this goes in again, I want to double check that this doesn't affect compile time on darwin + frameworks. Will get back to you asap.


================
Comment at: lib/Lex/PPDirectives.cpp:218
@@ +217,3 @@
+  SmallString<32> LowerInclude{Include};
+  for (char& Ch : LowerInclude) {
+    // In the ASCII range?
----------------
-> "char &Ch"

================
Comment at: lib/Lex/PPDirectives.cpp:1666
@@ +1665,3 @@
+    // not 100% correct in the presence of symlinks.
+    for(auto &Component : llvm::reverse(Components)) {
+      if ("." == Component) {
----------------
-> "for (auto..."


http://reviews.llvm.org/D19843