[PATCH] D20732: Don't use static variables in LambdaCapture
Faisal Vali via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 8 04:20:42 PDT 2016
faisalv added a comment.
Seems reasonable to me if we have the bit to spare. I wasn't a huge fan of the sentinel approach - but i appreciated Richard showing me that trick. I don't think I realized that Decl has to be aligned on an 8 byte boundary. I'm not too familiar with the alignment gymnastics - but I'm assuming you've given some thought to any existing pathological code that might break if the actual compile-time alignment of Decl itself is changed (since currently it seems to be that the alignment requirements are established at run-time and only through allocation via new (not that anyone would be creating Decls on the stack)) - and whether there are any consequences of relevance there...
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D20732
More information about the cfe-commits
mailing list