[PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

[pierre gousseau via cfe-commits]

pgousseau added a comment.

> > Are you asking for the 2 seconds tolerance to be part of this patch?

> 

> >  Or, as it seems the main problem here is the lack of a reproducible, are you ok with the idea of committing this patch first, to see if the inconsistent time stamps is still an issue?

> 

> 

> Yes, let's commit a patch to remove the #if first, and see if anything actually breaks (and if so, what). There's no need to add an option for this we have no uses for it.


Sounds good, does it mean it is ok to commit?
Sorry, regarding the option, not sure if you are saying: "if we have no uses for it" or "as we have no uses for it"?
The idea behind the option is to allow distributed builds system, that do not preserve time stamps, to use PCH files.


http://reviews.llvm.org/D20867