[PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 7 05:17:31 PDT 2016


hokein added inline comments.

================
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
 
 /// Finds and fixes header guards that do not adhere to LLVM style.
 class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
----------------
hokein wrote:
> madsravn wrote:
> > hokein wrote:
> > > You should add a document for the option `HeaderFileExtensions` here.
> > I'm not sure what you mean here. What is "a document" in this context?
> Sorry for the unclear comment. You actually add an option `HeaderFileExtensions` in `LLVMHeaderGuardCheck`, so you need to add a document to describe it. See the file `DefinitionsInHeadersCheck.h` for details.
You need to add a comment here, like:

```
/// Finds and fixes header guards that do not adhere to LLVM style.
///
///  The check supports these options:
///   - `HeaderFileExtensions`: a comma-separated list of filename extensions of
///     header files (The filename extension should not contain "." prefix).
///     ",h,hh,hpp,hxx" by default.
```


http://reviews.llvm.org/D20512





More information about the cfe-commits mailing list