[PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

Igor Sugak via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 6 19:15:34 PDT 2016


sugak added inline comments.

================
Comment at: clang-tidy/tool/clang-tidy-diff.py:42
@@ -41,3 +41,3 @@
                       help='path to clang-tidy binary')
   parser.add_argument('-p', metavar='NUM', default=0,
                       help='strip the smallest prefix containing P slashes')
----------------
Eugene.Zelenko wrote:
> Shouldn't -p be used to specify compile database as in run-clang-tidy.py?
>From the test plan it looks like this script doesn't support compilation database input:
```lang=bash
git diff -U0 HEAD^ | clang-tidy-diff.py -checks=-*,misc-use-override -p1 -- -std=gnu++14
```
It is similar to `patch`-like tools that process unified diff input -- uses `-p` to adjust file path. I can fix it in a separate diff, just need a better name for the current function of `-p`.


http://reviews.llvm.org/D21050





More information about the cfe-commits mailing list