[PATCH] D21022: [ARM] Fix linker emulation for arm 32 big endian

Peter Smith via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 6 08:56:33 PDT 2016


peter.smith added a comment.

That looks correct to me. Certainly armebelf_linux_eabi is not recognised on a recent ld.


================
Comment at: lib/Driver/Tools.cpp:9098
@@ -9097,3 +9097,3 @@
   case llvm::Triple::thumbeb:
-    return "armebelf_linux_eabi"; /* TODO: check which NAME.  */
+    return "armelfb_linux_eabi"; /* TODO: check which NAME.  */
   case llvm::Triple::ppc:
----------------
armelfb_linux_eabi matches the emulation name of my installation of gnu ld and the name in ld/configure.tgt. I think it is at least as authoratitive as armelf_linux_eabi so I suggest removing the /* TODO */ comment.


http://reviews.llvm.org/D21022





More information about the cfe-commits mailing list