r269670 - [OpenCL] Add supported OpenCL extensions to target info.

[Anastasia Stulova via cfe-commits]

Hi Jeroen,

I am not quite sure what your question is about in (a).

Regarding (b) please see example in test/SemaOpenCL/extensions.cl from the commit r269670.

Please note that SPIR target supports all extensions but disables them by default (see commit r269670). The latter logic hasn't been modified from earlier revisions of Clang.
Each targets can set the supported extensions as required, if you look at the latest commits: http://reviews.llvm.org/D20389

Perhaps, you can give us some code examples of what you believe isn't compiled correctly in Clang now. 

Thanks,
Anastasia

-----Original Message-----
From: Jeroen Ketema [mailto:j.ketema at imperial.ac.uk] 
Sent: 31 May 2016 23:07
To: Liu, Yaxun (Sam)
Cc: Anastasia Stulova; Clang Commits; nd
Subject: Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Sam,

> This commit does not change the initial state of the extensions. An extension is supported is not the same as enabled. At the beginning all extensions are disabled.

I do not see this reflected in the code at all. Could you please:

a. Point me to the location where this distinction is made.

b. Convince me that I cannot enable an extension for a target if that target does not support the extension?

Jeroen