[PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.
Benjamin Kramer via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 3 03:27:25 PDT 2016
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
LG. It's a bit sad but I guess the cases where that legitimately can happen due to template weirdness are far outweighed by the cases where we have a non-self contained header. The cases I've been thinking of are stuff like:
header.h:
template <typename T>
class Foo {
T t;
};
test.cc:
#include "header.h"
class Bar;
Foo<Bar> f;
Here we'd have to include the header for Bar into test.cc, but figuring that out is hard. Ignoring all of that for now is fine.
http://reviews.llvm.org/D20950
More information about the cfe-commits
mailing list