Don't pass --build-id by default.

Rafael EspĂ­ndola via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 2 15:55:25 PDT 2016


We do it just because gcc in some distributions do it.

I can see why --build-id is useful for distributions, but given the
cost on day to day edit+build cycles, any distro using clang should
really just pass -Wl,--build-id in rpmbuild (or corresponding tool).

Even upstream gcc is not as aggressive as current clang. It has a
--enable-linker-build-id configure option and it defaults to false.

Cheers,
Rafael
-------------- next part --------------
diff --git a/lib/Driver/ToolChains.cpp b/lib/Driver/ToolChains.cpp
index a26ca08..9b79bf9 100644
--- a/lib/Driver/ToolChains.cpp
+++ b/lib/Driver/ToolChains.cpp
@@ -3928,11 +3928,6 @@ Linux::Linux(const Driver &D, const llvm::Triple &Triple, const ArgList &Args)
   if (IsRedhat(Distro) && Distro != RHEL5 && Distro != RHEL6)
     ExtraOpts.push_back("--no-add-needed");
 
-  if ((IsDebian(Distro) && Distro >= DebianSqueeze) || IsOpenSUSE(Distro) ||
-      (IsRedhat(Distro) && Distro != RHEL5) ||
-      (IsUbuntu(Distro) && Distro >= UbuntuKarmic))
-    ExtraOpts.push_back("--build-id");
-
   if (IsOpenSUSE(Distro))
     ExtraOpts.push_back("--enable-new-dtags");
 


More information about the cfe-commits mailing list