[PATCH] D20886: [libcxxabi] Allow target flags to affect configuration tests.

[Eric Fiselier via cfe-commits]

EricWF added inline comments.

================
Comment at: CMakeLists.txt:201
@@ +200,3 @@
+  message(FATAL_ERROR "LIBCXXABI_BUILD_32_BITS=ON is not supported on this platform.")
+endif()
+
----------------
compnerd wrote:
> Why not handle this like libunwind?  Alternative, we could duplicate this into libunwind.  But we should behave similarly across the two I think.
I just forgot to copy/paste it. I'll check it in.

================
Comment at: CMakeLists.txt:219
@@ +218,3 @@
+    list(APPEND LIBCXXABI_LINK_FLAGS ${var})
+endmacro()
+
----------------
compnerd wrote:
> No CMAKE_LINKER_FLAGS like libunwind/libc++?
`CMAKE_LINKER_FLAGS` isn't a thing. libunwind and libc++ both use `<PROJECT>_LINK_FLAGS`.

Also `CMAKE_COMPILE_FLAGS` is not a CMake variable either. (which I did replace in libunwind).


http://reviews.llvm.org/D20886