[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept
Piotr Padlewski via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 1 04:29:05 PDT 2016
Prazek added a comment.
In http://reviews.llvm.org/D19201#445496, @aaron.ballman wrote:
> In http://reviews.llvm.org/D19201#445406, @sbarzowski wrote:
>
> > Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same expr in multiple noexcepts, then it returns the same object for all of them, so it is useless for determining the location in code.
> >
> > I ended up finding it all "by hand" with lexer (looking for matching parentheses).
>
>
> I think you may want to take a dependency on: http://reviews.llvm.org/D20428
We will see how much time it will take to make it pushable to master. IMHO this code is not complicated enough to make it wait for your patch, but it's cool that you took care of it :)
Repository:
rL LLVM
http://reviews.llvm.org/D19201
More information about the cfe-commits
mailing list