[PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

[Adrian Prantl via cfe-commits]

aprantl added inline comments.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3427
@@ -3425,3 +3426,3 @@
         DContext, DeclName, LinkageName, Unit, LineNo, getOrCreateType(T, Unit),
-        Var->hasInternalLinkage(), Var,
+        Var->hasInternalLinkage(), nullptr,
         getOrCreateStaticDataMemberDeclarationOrNull(D));
----------------
aprantl wrote:
> I think it would be more readable to pass an empty DIExpression() here.
/* expression=*/ is good enough.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3474
@@ -3472,1 +3473,3 @@
     return;
+  llvm::DIExpression *InitExpr = nullptr;
+  if (Init.isInt())
----------------
aprantl wrote:
> Shouldn't the default constructor of DIExpression() wrap an MDNode nullptr?
Sorry, that was a couple of IR evolution steps ago. DIExpression now inserts from MDNode.


http://reviews.llvm.org/D20415