[PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

[Eric Fiselier via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

Just for reference here is a list of symbols which have been removed:

https://gist.github.com/EricWF/bf00dbc5fccc78b779f8d260727a0710

LGTM. Your free to submit it after addressing the inline comments.


================
Comment at: test/cxa_bad_cast.pass.cpp:40
@@ +39,3 @@
+    } catch (std::bad_cast) {
+        assert(true);
+    } catch (...) {
----------------
return 0;

================
Comment at: test/cxa_bad_cast.pass.cpp:45
@@ +44,3 @@
+#endif
+    return 0;
+}
----------------
return 1;

================
Comment at: test/cxa_bad_typeid.pass.cpp:39
@@ +38,3 @@
+    } catch (std::bad_typeid) {
+        assert(true);
+    } catch (...) {
----------------
return 0 here instead. "assert(true)" is pretty much un-observable.

================
Comment at: test/cxa_bad_typeid.pass.cpp:44
@@ +43,3 @@
+#endif
+    return 0;
+}
----------------
This should return non-zero.

================
Comment at: test/noexception1.pass.cpp:26
@@ +25,3 @@
+int main ()
+{
+    std::set_terminate(my_terminate);
----------------
Before setting the terminate handling call the function once with null to make sure it returns.

================
Comment at: test/noexception2.pass.cpp:26
@@ +25,3 @@
+int main ()
+{
+    std::set_terminate(my_terminate);
----------------
Before setting the terminate handling call the function once with null to make sure it returns.

================
Comment at: test/noexception3.pass.cpp:27
@@ +26,3 @@
+{
+    std::set_terminate(my_terminate);
+    __cxxabiv1::__cxa_rethrow_primary_exception((void*) &gCounter);
----------------
Before setting the terminate handling call the function once with null to make sure it returns.


http://reviews.llvm.org/D20677