[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

[Alexander Kornienko via cfe-commits]

alexfh added a comment.

Thank you for the new check!

Before starting with the review, I'd like to clarify one important thing. It's not immediately obvious that the pattern the check detects is actually a good indicator of a programming mistake. Did you try to run the check on a large enough codebase (at least, on the whole LLVM project) and analyze the results? http://clang.llvm.org/extra/clang-tidy/#running-clang-tidy-on-llvm describes the recommended way to run clang-tidy on LLVM.


http://reviews.llvm.org/D20689