[PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Thu May 26 08:08:55 PDT 2016


Anastasia added a subscriber: Anastasia.

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900
@@ -7897,1 +7899,3 @@
+def ext_opencl_ext_vector_type_rgba_selector: ExtWarn<
+  "vector component name '%0' is an OpenCL 2.2 extension">;
 } // end of sema category
----------------
Could it be an error instead for CL <2.2? It isn't a valid feature and we have already rejected similar cases with an error. 

How about changing to something like:
  "vector component name '%0' is not supported in earlier than OpenCL version 2.2"

See similar diagnostics above - err_opencl_invalid_read_write, err_opencl_unknown_type_specifier.

Using extension might be confusing because we have core spec and extension spec in OpenCL.


http://reviews.llvm.org/D20602





More information about the cfe-commits mailing list