[PATCH] D19909: [Attr] Add support for the `ms_hook_prologue` attribute.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu May 26 04:55:56 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM (when Sanjoy's patch goes in), with two minor nits.

Can you also add a test that the attribute fails on one of the target architectures Windows does not support?


================
Comment at: include/clang/Basic/AttrDocs.td:506
@@ +505,3 @@
+
+.. _`/HOTPATCH`: https://msdn.microsoft.com/en-us/library/ms173507.aspx
+  }];
----------------
Should document that we disallow it in conjunction with naked, always_inline, and __forceinline.


http://reviews.llvm.org/D19909





More information about the cfe-commits mailing list