[PATCH] D20660: Remove `auto_ptr` in C++17.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 21:38:42 PDT 2016


EricWF added a comment.

A couple of comments.

1. there's probably a better way to state `_LIBCPP_STD_VER <= 14 || defined(_LIBCPP_NO_REMOVE_AUTO_PTR)`. Maybe `_LIBCPP_HAS_NO_AUTO_PTR` which `__config` defines if `_LIBCPP_STD_VER > 14 && !defined(_LIBCPP_NO_REMOVE_AUTO_PTR)`.

2. `// XFAIL c++1z` is eventually going to be a pain to maintain. I'll  try and come up with a better way to state this condition in the test suite.


http://reviews.llvm.org/D20660





More information about the cfe-commits mailing list