[PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 15:20:50 PDT 2016


rsmith added a comment.

In http://reviews.llvm.org/D18035#437715, @rengolin wrote:

> The 3.8.1 deadline is tomorrow and I'd really like to see these two patches (plus the related fixes) in it,


Realistically, this seems unlikely to make it in time.

> or some LTS Linux distributions will live without them, and thus with completely broken copies of LLVM.


No, they'll be shipping with a broken copy of their C++ standard library, and will fail to conform to the Linux Standards Base specifications due to deviating from the Itanium C++ ABI. This patch is working around another popular implementation's failure to follow the relevant specification, nothing more. Please try to appropriately apportion the responsibility here; if your distribution opted into a non-standard ABI for their C++ standard library, you should point out to them that they made a mistake.


http://reviews.llvm.org/D18035





More information about the cfe-commits mailing list