[PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8
John McCall via cfe-commits
cfe-commits at lists.llvm.org
Wed May 25 14:11:48 PDT 2016
rjmccall added a comment.
In http://reviews.llvm.org/D20407#439887, @ahatanak wrote:
> I reverted the changes I made in SemaDeclObjC.cpp as they weren't needed to pass the regression tests I added. clang still asserts when it compiles an objective-c method returning _Atomic and those changes will become necessary when I fix that later. Normal functions returning _Atomic doesn't compile either.
The C standard is poorly-written in this area, but I think it would be reasonable for CheckFunctionReturnType to just silently remove _Atomic. (You will not be able to just re-use your new method there; removing other qualifiers is not acceptable, I'm afraid.)
http://reviews.llvm.org/D20407
More information about the cfe-commits
mailing list