[PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

[Richard Smith via cfe-commits]

rsmith added inline comments.

================
Comment at: lib/Basic/FileManager.cpp:389
@@ -383,2 +388,3 @@
   UFE->File.reset();
+  UFE->IsVirtual = true;
   return UFE;
----------------
Rather than adding this `IsVirtual` flag, could you just set `UFE->IsValid` to `true` here?  It looks like a simple oversight that this code fails to set the `IsValid` flag properly.


Repository:
  rL LLVM

http://reviews.llvm.org/D20338